Skip to content

Desktop: Add File > Save As… - #3034

Merged
timon-schelling merged 19 commits into
masterfrom
improve-save-document
Aug 20, 2025
Merged

timon-schelling merged 19 commits into
masterfrom
improve-save-document

Conversation

@timon-schelling

@timon-schelling timon-schelling commented Aug 9, 2025 •

Copy link
Copy Markdown
Member

Closes #2973.

  • Improve save document semantics
    • Removes name from values saved in document (No migration should be needed)
    • Instead uses file name (without .graphite) as the document name
    • Document name is updated when the document path is updated
    • Document path is reset if the name is change by the user
  • Add Save as action
    • Adds Save As Menu entry and shortcut
    • Issue: Save as shourtcut Ctrl + Shift + S not working (help wanted)

@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 9, 2025 14:17 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 9, 2025 16:27 Inactive
@timon-schelling
timon-schelling marked this pull request as ready for review August 10, 2025 00:39
@timon-schelling
timon-schelling requested a review from Keavon August 10, 2025 00:40
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 11, 2025 09:55 Inactive
@TrueDoctor

Copy link
Copy Markdown
Member

@Keavon We fixed the open issue this is now waiting on your thoughts regarding how the save process flow should work and if the implemented behaviour is desired

@GraphiteEditor GraphiteEditor deleted a comment from github-actions Bot Aug 11, 2025
@Keavon

Keavon commented Aug 11, 2025

Copy link
Copy Markdown
Member

Let's discuss in a call so I know more about what's to be considered.

Also, this PR has a conflict.

@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 11, 2025 17:58 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 11, 2025 18:09 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 11, 2025 20:06 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 11, 2025 20:56 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 12, 2025 08:52 Inactive
@github-actions

This comment was marked as off-topic.

@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 13, 2025 21:51 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 14, 2025 12:34 Inactive
@TrueDoctor

Copy link
Copy Markdown
Member

@Keavon what is the status on this? I can review the code you just have to say if you are happy with the behaviour

@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 18, 2025 20:38 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 20:53 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 21:08 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 21:27 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 21:37 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 22:01 Inactive
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 19, 2025 23:11 Inactive
@Keavon Keavon changed the title Improve save document semantics and add save as action Improve document save semantics and add "Save As…" action Aug 20, 2025
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 09:07 Inactive
@Keavon Keavon changed the title Improve document save semantics and add "Save As…" action Desktop: Add the File > Save As… on desktop Aug 20, 2025
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 09:50 Inactive
@TrueDoctor TrueDoctor changed the title Desktop: Add the File > Save As… on desktop Desktop: Add File > Save As… Aug 20, 2025
@timon-schelling
timon-schelling enabled auto-merge (squash) August 20, 2025 09:59
@github-actions
github-actions Bot temporarily deployed to graphite-dev (Preview) August 20, 2025 10:01 Inactive
@timon-schelling
timon-schelling merged commit e70862b into master Aug 20, 2025
@timon-schelling
timon-schelling deleted the improve-save-document branch August 20, 2025 10:09

This branch was previously deployed

1 inactive deployment
graphite-dev (Preview) — fa02559a Deployed Aug 20, 2025 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move file handling to native code

3 participants